firebase - Multiple sign out methods in one function in Swift -


i wondering if can or ok practice bunch 2 methods signing out (facebook , google) in 1 function call? have signout button , when facebook user signs out sign out of facebook, , of course when google user logged in sign out of google. or should create conditional inside sign out function? , help!

 // handle sign out function     func handlesignout() {          let firebaseauth = firauth.auth()         {             try firebaseauth?.signout()         } catch let signouterror nserror {             print ("error signing out: %@", signouterror)         }          // facebook sign out         userdefaults.standard.setisloggedin(value: false)         fbsdkloginmanager().logout()         print("did log out of facebook...")          // google sign out         userdefaults.standard.setisloggedin(value: false)         gidsignin.sharedinstance().signout()         print("did log out of google...")          if firauth.auth()?.currentuser == nil {             let logincontroller = logincontroller()             present(logincontroller, animated: true, completion: nil)         }     } 

there shouldn't problem doing decrease efficiency of code firebase still check if other types of users signed even after user has signed out once. again, shouldn't of problem, benefits outweigh cons of having conditional inside function. anyway, easy conditional.


Comments